chore: fix incorrect version notation of GQL Field #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
…d-version' into chore/clear-resource-policy-field-version
kyujin-cho
changed the title
…d-version' into chore/clear-resource-policy-field-version
…d-version' into chore/clear-resource-policy-field-version
…d-version' into chore/clear-resource-policy-field-version
…d-version' into chore/clear-resource-policy-field-version
…d-version' into chore/clear-resource-policy-field-version
kyujin-cho
approved these changes
May 27, 2024
kyujin-cho
added
area:docs
Graphite App
agatha197
reviewed
May 27, 2024
…d-version' into chore/clear-resource-policy-field-version
lablup-octodog
pushed a commit
that referenced
this pull request
May 27, 2024
Co-authored-by: Sion Kang <siontama@gmail.com> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 1993
|
Backport to 23.09 is failed. Please backport manually. |
fregataa
added a commit
that referenced
this pull request
May 27, 2024
Backported-from: main (24.09) Backported-to: 23.09 Co-authored-by: Sion Kang <siontama@gmail.com>
yomybaby
pushed a commit
to lablup/backend.ai-webui
that referenced
this pull request
May 28, 2024
follows #2357 Add User Resource Policy Page ## Description - Add User resource policy CRUD. - Add `FormItemProps` props to `FormItemWithUnlimited`. - Add simple error handler to `KeypairResourcePolicySettingModal`. - Remove unused component, `ResourcePolicyCard`. ## Checklist - [ ] List Page: name, max folder count, max session count per model session, max quota scope size, id, created at - [ ] Each item will be shown/hidden according to the server version. - [ ] In particular, it is stated in the schema that `max_vfolder_count` is supported from version 24.03.1, but this is incorrectly documented, and it follows lablup/backend.ai#1993. - [ ] `max_session_count_per_model_session` is supported from version 23.09.10 as follows lablup/backend.ai#1993 too. - [ ] Create/Modal: Create or modify user resource policy. - [ ] Version compatibility is the same as the list. - [ ] Unlimited value of `Max Folder Count` is 0. - [ ] Unlimited value of `Max Folder Size` is -1. ## Screenshots <table> <tr> <td> <td>24.03.0b1 (10.82.230.101)</td> <td>24.09.0dev1 (main)</td> <tr> <td>List</td> <td>  </td> <td>  </td> <tr> <td>Create Modal</td> <td>  </td> <td>  </td> <tr> <td>Modify Modal</td> <td>  </td> <td>  </td> </tr> <tr> <td>Table Setting</td> <td>  </td> <td>  </td> </tr> </table> **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
pushed a commit
to lablup/backend.ai-webui
that referenced
this pull request
May 28, 2024
follows #2357 Add Project Resource Policy Page ### TL;DR This pull request introduces changes related to FormItemWithUnlimited and ProjectResourcePolicyList components. ### What changed? The changes include: - Addition of FormItemWithUnlimitedProps in `FormItemWithUnlimited` component - Updates to `ProjectResourcePolicyList` component with enhanced functionality and UI improvements ### Checklist - [ ] List Page: name, max folder count, max quota scope size, id, created at - [ ] Each item will be shown/hidden according to the server version. - [ ] In particular, it is stated in the schema that `max_vfolder_count` is supported from version 24.03.1, but this is incorrectly documented, and it follows lablup/backend.ai#1993. - [ ] Create/Modal: Create or modify project resource policy. - [ ] Version compatibility is the same as the list. - [ ] Unlimited value of `Max Folder Count` is 0. - [ ] Unlimited value of `Max Folder Size` is -1. ### Screenshots <table> <tr> <td></td> <td>24.03.0b1 (10.82.230.101)</td> <td>24.09.0dev1 (main)</td> </tr> <tr> <td>List</td> <td>  </td> <td>  </td> </tr> <tr> <td>Create Modal</td> <td>  </td> <td>  </td> </tr> <tr> <td>Modify Modal</td> <td>  </td> <td>  </td> </tr> <tr> <td>Table Setting</td> <td>  </td> <td>  </td> </tr> </table> --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
kyujin-cho
pushed a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: Sanghun Lee <sanghun@lablup.com> Co-authored-by: Sion Kang <siontama@gmail.com> Backported-from: main (24.09) Backported-to: 24.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by #2000
Change
Added in {VERSION}andDeprecated since {VERSION}for consistency..(dot). e.g. "23.09.10" -> "23.09.10."Why are the versions so different?
KeyPairResourcePolicy
max_quota_scope_sizefield was added by mistake in version "23.09.6", when fix: restore removed graphene fields and set them deprecated #1677 was backported (a4bad32)UserResourcePolicy, ProjectResourcePolicy
max_vfolder_sizewas actually deprecated since "23.09.2", when fix: provide deprecation msg tomax_vfolder_sizegraphene field #1644 was backported (2a1cc67){Create/Modify}UserResourcePolicyInput, ProjectResourcePolicyInput
max_vfolder_sizefield that was removed when fix: provide deprecation msg tomax_vfolder_sizegraphene field #1644 was backported to "23.09.2" (2a1cc67)Warning
in 23.09,
max_vfolder_countfield of {User/Project}ResourcePolicy was removed in "23.09.3." by mistake and restored in "23.09.6.". So, the version the field was added in is "23.09.6."max_vfolder_countfrom {User/Project}ResourcePolicy: f4d6b51Some fields has a different version in each major version. e.g. {User/Project}ResourcePolicy has
max_vfolder_countfield and it was added in "24.03.1" and "23.09.6".Checklist: (if applicable)
docsdirectory📚 Documentation preview 📚: https://sorna--1993.org.readthedocs.build/en/1993/
📚 Documentation preview 📚: https://sorna-ko--1993.org.readthedocs.build/ko/1993/